Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod,x-pack/filebeat/input/cel: update mito dependency #33974

Merged
merged 2 commits into from
Dec 7, 2022
Merged

mod,x-pack/filebeat/input/cel: update mito dependency #33974

merged 2 commits into from
Dec 7, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 7, 2022 •
edited
Loading

What does this PR do?

This brings in improvements in the collection extension behaviour and support for context.Context in the HTTP extension.

elastic/mito@2f0f2875 lib: add HTTPWithContext cel.EnvOption
elastic/mito@fa5b7a0f lib: allow specification of dotted path elements in collate and drop

Why is it important?

These are optimisations for cancellation and improvements to handling JSON paths.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 7, 2022
@efd6
mod,x-pack/filebeat/input/cel: update mito dependency
296d5b6 
This brings in improvments in the collection extension behaviour and
support for context.Context in the HTTP extension.

2f0f2875 lib: add HTTPWithContext cel.EnvOption
fa5b7a0f lib: allow specification of dotted path elements in collate and drop
@mergify mergify bot assigned efd6 Dec 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @efd6? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.7-candidate labels Dec 7, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 7, 2022
@efd6 efd6 marked this pull request as ready for review December 7, 2022 03:55
@efd6 efd6 requested review from a team as code owners December 7, 2022 03:55
@efd6 efd6 requested review from cmacknz and leehinman and removed request for a team December 7, 2022 03:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shuts down like a charm now. 😄

x-pack/filebeat/docs/inputs/input-cel.asciidoc Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 7, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-07T04:52:35.747+0000

  • Duration: 132 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 25062
Skipped 1954
Total 27016

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@efd6 efd6 merged commit 4408e14 into elastic:main Dec 7, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
mod,x-pack/filebeat/input/cel: update mito dependency (#33974)
74e726a 
This brings in improvements in the collection extension behaviour and
support for context.Context in the HTTP extension.

2f0f2875 lib: add HTTPWithContext cel.EnvOption
fa5b7a0f lib: allow specification of dotted path elements in collate and drop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz was automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.7-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh